Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geomagic] Update demo scenes to use direct solvers. #1533

Merged
merged 2 commits into from
Oct 22, 2020
Merged

[Geomagic] Update demo scenes to use direct solvers. #1533

merged 2 commits into from
Oct 22, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 12, 2020

  • Update some demo scenes to have a better physics approach direct solvers.
  • Add an example with several deformable cubes

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 12, 2020
@epernod epernod self-assigned this Oct 12, 2020
@epernod
Copy link
Contributor Author

epernod commented Oct 12, 2020

[ci-build][with-all-tests]

2 similar comments
@epernod
Copy link
Contributor Author

epernod commented Oct 18, 2020

[ci-build][with-all-tests]

@epernod
Copy link
Contributor Author

epernod commented Oct 19, 2020

[ci-build][with-all-tests]

hugtalbot
hugtalbot reviewed Oct 19, 2020
View reviewed changes
applications/plugins/Geomagic/scenes/Geomagic-DeformableCubes.scn
<TetrahedralCorotationalFEMForceField name="FEM" youngModulus="100" poissonRatio="0.3" method="large" topology="@Tetra_topo2"/>
<UniformMass totalMass="0.1" />
<LinearSolverConstraintCorrection />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR aims at using the SparseLDL (direct) with a proper Lagrange-based constraint resolution with the full A matrix recovered by the LinearSolverConstraintCorrection, right ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah! You got it baby!

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 21, 2020
@guparan guparan merged commit 27534f6 into sofa-framework:master Oct 22, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@epernod epernod deleted the inf_geomagic_demo branch November 20, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @hugtalbot @guparan