Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Improve check for already registered plugins #1472

Merged
merged 4 commits into from
Sep 17, 2020
Merged

[SofaKernel] Improve check for already registered plugins #1472

merged 4 commits into from
Sep 17, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Sep 7, 2020 •
edited
Loading

Several changes in PluginManager:

  • Add check to avoid registering the same plugin from different paths
  • Change method getPlugin to look in the map of registered plugin using the plugin name instead of using a reconstructed path.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 7, 2020
@epernod epernod self-assigned this Sep 7, 2020
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 9, 2020
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 10, 2020
@guparan guparan changed the title [SofaKernel] Small changes in PluginManager [SofaKernel] Improve check for already registered plugin Sep 16, 2020
@guparan guparan changed the title [SofaKernel] Improve check for already registered plugin [SofaKernel] Improve check for already registered plugins Sep 16, 2020
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 16, 2020
@hugtalbot
Copy link
Contributor

Ci is fine

@guparan guparan merged commit c10f280 into sofa-framework:master Sep 17, 2020
@epernod epernod deleted the inf_pluginMgr branch October 9, 2020 22:25
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@epernod epernod mentioned this pull request Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @hugtalbot @guparan