Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Switch to include_guard() instead of include_guard(GLOBAL) #1467

Merged
merged 1 commit into from
Aug 28, 2020
Merged

[SofaKernel] Switch to include_guard() instead of include_guard(GLOBAL) #1467

merged 1 commit into from
Aug 28, 2020

Conversation

damienmarchal
Copy link
Contributor

It was reported that include_guard(GLOBAL) is problematic with third-party plugins so let's go back to the "normal" version.

Signed-off-by: Damien Marchal damien.marchal@univ-lille1.fr

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[SofaKernel] Switch to include_guard() instead of include_guard(GLOBAL)
7a8f073 
Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
@damienmarchal damienmarchal added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Aug 28, 2020
@epernod epernod added the pr: status ready Approved a pull-request, ready to be squashed label Aug 28, 2020
@epernod epernod merged commit 295ca80 into sofa-framework:master Aug 28, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @guparan @epernod