[All] Replace all sofa::defaulttypes::RGBAColor to sofa::helper::types::RGBAColor #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: status to review
damienmarchal
force-pushed
the
pr-replace-old-rgbacolors
branch
from
33408d8
to
40f197d
Compare
damienmarchal
added
pr: status ready
guparan
changed the title
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Feb 23, 2024
…s::RGBAColor (sofa-framework#1463) * [all] Replace all sofa::defaulttypes::RGBAColor to sofa::helper::types::RGBAColor * [SofaHelper] Add RGBAColor_fwd.h for forward declaration. * [SofaHelper] update RGBAColor_fwd.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not supposed to be breaking but one day we will totally remove the sofa::defaulttype::RGBAColor.
This PR:
Reviewers will merge only if all these checks are true.