Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Implement an update mechanism on component: RequiredPlugin #1458

Merged
merged 2 commits into from
Aug 27, 2020
Merged

[SofaKernel] Implement an update mechanism on component: RequiredPlugin #1458

merged 2 commits into from
Aug 27, 2020

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Aug 25, 2020 •
edited
Loading

RequriedPlugin does not updates when some of its data field are changed.
This PR implement this behavior without breaking the existing one.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request labels Aug 25, 2020
damienmarchal added a commit to SofaDefrost/sofa that referenced this pull request Aug 25, 2020
@damienmarchal
Merge the pending PR sofa-framework#1458 on top of upstream/master
7989bda
@damienmarchal damienmarchal added pr: fix Fix a bug and removed pr: new feature Implement a new feature labels Aug 25, 2020
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 26, 2020
@damienmarchal
[SofaKernel] Implement an update mechanism on component: RequiredPlugin
6f687e1
@damienmarchal
[SofaGraphComponent] Update the SceneCheckMissingRequiredPlugin to us…
b214933 
…e the introduced d_loadedPlugins instead of d_pluginName

d_pluginName is containing a list of name to try while d_loadedPlugins is
the list of plugin that have been actually loaded.
@damienmarchal damienmarchal force-pushed the pr-add-update-for-requiredplugin branch from 1b79b0c to b214933 Compare August 26, 2020 22:11
@damienmarchal damienmarchal merged commit 9730f76 into sofa-framework:master Aug 27, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marques-bruno marques-bruno marques-bruno approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
4 participants
@damienmarchal @marques-bruno @hugtalbot @guparan