Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Fix Cmake configure step with SOFA_WITH_DEPRECATED_COMPONENTS #1452

Merged
merged 1 commit into from
Aug 24, 2020
Merged

[CMake] Fix Cmake configure step with SOFA_WITH_DEPRECATED_COMPONENTS #1452

merged 1 commit into from
Aug 24, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Aug 17, 2020

SOFA_WITH_DEPRECATED_COMPONENTS option was declared after it was supposed to be used in SofaFramework's own CMakeLists. Therefore CMake was throwing an error at the first step here

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Aug 17, 2020
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 19, 2020
@hugtalbot hugtalbot merged commit 89895be into sofa-framework:master Aug 24, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@fredroy fredroy deleted the fix_cmake_depr_comp branch December 10, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @hugtalbot @guparan