Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InvertibleFVM] Externalize the plugin #1443

Merged
merged 4 commits into from
Aug 6, 2020
Merged

[InvertibleFVM] Externalize the plugin #1443

merged 4 commits into from
Aug 6, 2020

Conversation

hugtalbot
Copy link
Contributor

First plugin to be moved out, as detailed in issue #1442
Plugin is now located here: https://github.com/sofa-framework/InvertibleFVM

All feedback are more than welcome.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels Jul 30, 2020
guparan
guparan suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not mess with sofa_add_plugin calls order in applications/plugins/CMakeLists.txt, it's this way because of dependencies between plugins.
TODO: reset this file and just replace sofa_add_plugin(InvertibleFVM InvertibleFVM) by sofa_add_plugin_external(InvertibleFVM InvertibleFVM)

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 30, 2020
@hugtalbot hugtalbot requested a review from guparan July 30, 2020 16:15
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Aug 2, 2020
@hugtalbot
Copy link
Contributor Author

Hmm thanks @guparan I misunderstood the expected change 👍

@guparan
Merge remote-tracking branch 'sofa-framework/master' into MoveOut_Inv…
517c737 
…ertibleFVM

# Conflicts:
#	applications/plugins/InvertibleFVM/CMakeLists.txt
@guparan
Copy link
Contributor

guparan commented Aug 4, 2020

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 5, 2020
@epernod epernod merged commit 905b6f2 into sofa-framework:master Aug 6, 2020
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@guparan guparan changed the title [plugins] Apply move out plugin InvertibleFVM [InvertibleFVM] Externalize the plugin Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod Awaiting requested review from epernod

@guparan guparan Awaiting requested review from guparan

Assignees
No one assigned
Labels
pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @guparan @epernod