Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Geomagic] Fix scenes ForceFeedBack behavior due to a change in UncoupledConstraintCorrection #1435

Merged
merged 1 commit into from
Aug 12, 2020
Merged

[Geomagic] Fix scenes ForceFeedBack behavior due to a change in UncoupledConstraintCorrection #1435

merged 1 commit into from
Aug 12, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 21, 2020

Haptic scenes behavior has been changed by PR #1369
Modify them to match the old behavior

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added location: plugins pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: backport done This PR has been backported into the release before its milestone. labels Jul 21, 2020
@epernod epernod requested a review from hugtalbot July 21, 2020 21:07
@epernod epernod self-assigned this Jul 21, 2020
@hugtalbot
Copy link
Contributor

Change instead the factor in LCPFF to scale the force.

@hugtalbot
Copy link
Contributor

Inform users on the forum: https://www.sofa-framework.org/community/forum/topic/forces-not-getting-rendered-with-geomagic-touch/

@damienmarchal
Copy link
Contributor

Do we merge the PR ?

@epernod epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 25, 2020
@epernod
Copy link
Contributor Author

epernod commented Jul 25, 2020

no, not the good solution to change this option.

@epernod
Copy link
Contributor Author

epernod commented Aug 12, 2020

the new factors/parameters were set arbitrary using qualitative tests as we still don't have automatic test on this plugin.

@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Aug 12, 2020
@guparan guparan merged commit d3aee47 into sofa-framework:master Aug 12, 2020
@epernod epernod deleted the inf_geomagic2 branch August 12, 2020 17:38
@guparan guparan added this to the v20.12 milestone Nov 17, 2020
@guparan guparan added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport done This PR has been backported into the release before its milestone. labels Feb 18, 2021
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

Assignees

@epernod epernod

Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
4 participants
@epernod @hugtalbot @damienmarchal @guparan