Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Fix warnings due to visibility attribute #1421

Merged
merged 3 commits into from
Jun 23, 2020
Merged

[all] Fix warnings due to visibility attribute #1421

merged 3 commits into from
Jun 23, 2020

Conversation

hugtalbot
Copy link
Contributor

Just not 100% sure for LCPcalc.h and OglModelPolicy.h
Else we should get back to original warning number.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 15, 2020
damienmarchal
damienmarchal approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@damienmarchal damienmarchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hugo,

Thanks for the PR. You are right about the typedefs...they does not need visilibty declaration as these lines are not "something" that results in the binary files.
Everything is ok for me.

@hugtalbot
Copy link
Contributor Author

Cool that's how I understood it as well !

@marques-bruno marques-bruno self-requested a review June 23, 2020 13:58
@marques-bruno marques-bruno added the pr: status ready Approved a pull-request, ready to be squashed label Jun 23, 2020
@marques-bruno marques-bruno merged commit e6118eb into sofa-framework:master Jun 23, 2020
@guparan guparan added this to the v20.06 milestone Jun 25, 2020
@hugtalbot hugtalbot removed the pr: status to review To notify reviewers to review this pull-request label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal damienmarchal approved these changes

@marques-bruno marques-bruno marques-bruno approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
4 participants
@hugtalbot @damienmarchal @marques-bruno @guparan