Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Fix hexahedra detection in BoxROI #1417

Merged
merged 2 commits into from
Jun 12, 2020
Merged

[SofaKernel] Fix hexahedra detection in BoxROI #1417

merged 2 commits into from
Jun 12, 2020

Conversation

andrea-mendizabal
Copy link

@andrea-mendizabal andrea-mendizabal commented Jun 11, 2020 •
edited by hugtalbot
Loading

A break is present in the doUpdate function making the detection of all hexahedra fail

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot changed the title corrected bug in hexahedra detection [SofaKernel] Fix hexahedra detection in BoxROI Jun 11, 2020
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jun 11, 2020
@epernod epernod added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jun 11, 2020
@epernod
Copy link
Contributor

epernod commented Jun 11, 2020

Nice one, this is indeed a bug. Behavior was changed in PR #108 and this loop was forgotten.

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 12, 2020
@guparan guparan merged commit b2abf6f into sofa-framework:master Jun 12, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
5 participants
@andrea-mendizabal @hugtalbot @epernod @guparan @AndreaMendizabal