-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Create an IDE folder for all relocatable_install targets #1405
[CMake] Create an IDE folder for all relocatable_install targets #1405
Conversation
[ci-build][with-all-tests] |
@@ -705,6 +705,7 @@ function(sofa_set_install_relocatable target install_dir) | |||
|| true | |||
) | |||
endif() | |||
set_target_properties(${target}_relocatable_install PROPERTIES FOLDER "relocatable_install") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put them next to their corresponding project with
get_target_property(target_folder ${target} FOLDER)
set_target_properties(${target}_relocatable_install PROPERTIES FOLDER ${target_folder})
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a comment maybe ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#prout!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to see relocatable_install projects so it's better to have them all in one folder and ignore it.
In an IDE (Visual Studio at least), tidy cozily all *_relocatable_install projects into a folder.
Before:
After:
This PR:
Reviewers will merge only if all these checks are true.