Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Create an IDE folder for all relocatable_install targets #1405

Merged
merged 1 commit into from
Jun 11, 2020
Merged

[CMake] Create an IDE folder for all relocatable_install targets #1405

merged 1 commit into from
Jun 11, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jun 4, 2020

In an IDE (Visual Studio at least), tidy cozily all *_relocatable_install projects into a folder.
Before:
Capture1
After:
Capture2

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jun 4, 2020
@fredroy
Copy link
Contributor Author

fredroy commented Jun 6, 2020

[ci-build][with-all-tests]

@hugtalbot hugtalbot requested a review from guparan June 8, 2020 09:00
guparan
guparan reviewed Jun 8, 2020
View reviewed changes
SofaKernel/SofaFramework/SofaMacros.cmake
@@ -705,6 +705,7 @@ function(sofa_set_install_relocatable target install_dir)
|| true
)
endif()
set_target_properties(${target}_relocatable_install PROPERTIES FOLDER "relocatable_install")
Copy link
Contributor

@guparan guparan Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put them next to their corresponding project with

get_target_property(target_folder ${target} FOLDER)
set_target_properties(${target}_relocatable_install PROPERTIES FOLDER ${target_folder})

What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment maybe ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#prout!?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to see relocatable_install projects so it's better to have them all in one folder and ignore it.

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 10, 2020
@guparan guparan merged commit 89c47f8 into sofa-framework:master Jun 11, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@fredroy fredroy deleted the ide_relocatable_targets_folder branch June 16, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@hugtalbot hugtalbot hugtalbot left review comments

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @guparan @hugtalbot @epernod