Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Clean due to doc #1398

Merged
merged 4 commits into from
Jun 3, 2020
Merged

[all] Clean due to doc #1398

merged 4 commits into from
Jun 3, 2020

Conversation

hugtalbot
Copy link
Contributor

Work done further to a doc update:

  • example scene of Newmark solver is improved
  • example scene for the PointsFromIndices engine is added
  • clean Newmark c++ code

FYI doc is here

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 27, 2020
guparan
guparan reviewed Jun 2, 2020
View reviewed changes
modules/SofaMiscSolver/NewmarkImplicitSolver.cpp Outdated
Comment on lines 100 to 102
msg_info() << "NewmarkImplicitSolver, aPrevious = " << a;
msg_info() << "NewmarkImplicitSolver, xPrevious = " << pos;
msg_info() << "NewmarkImplicitSolver, vPrevious = " << vel;
Copy link
Contributor

@guparan guparan Jun 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NewmarkImplicitSolver, is not needed (everywhere in this file)

@guparan
Copy link
Contributor

guparan commented Jun 2, 2020

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 3, 2020
@epernod epernod merged commit 910480a into sofa-framework:master Jun 3, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan left review comments

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @guparan @epernod