Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Add DataTypeInfo for BoundingBox #1373

Merged
merged 3 commits into from
May 27, 2020
Merged

[SofaKernel] Add DataTypeInfo for BoundingBox #1373

merged 3 commits into from
May 27, 2020

Conversation

marques-bruno
Copy link
Member

Hey dear reviewers... I'd like you to pay close attention to the size() and size(const DataType & /*data*/) functions... To me both the documentation in DataTypeInfo.h is incorrect

Depending on your answers correct the doc in DataTypeInfo.h in this PR

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels May 7, 2020
@marques-bruno marques-bruno self-assigned this May 7, 2020
@hugtalbot hugtalbot changed the title ADD: DataTypeInfo for BoundingBox [SofaKernel] Add DataTypeInfo for BoundingBox May 9, 2020
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

Then ready if it passes

@marques-bruno
Copy link
Member Author

Looks ok. Ready?

@hugtalbot
Copy link
Contributor

hugtalbot commented May 15, 2020 •
edited
Loading

new warnings are added, aren't there?

@marques-bruno
Copy link
Member Author

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

CI on CentOS not happy with CUDA and stopped on MacOS.
Let's restart it to check (Mac) with the tests!

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 27, 2020
@epernod epernod merged commit 720e626 into sofa-framework:master May 27, 2020
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees

@marques-bruno marques-bruno

Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
4 participants
@marques-bruno @hugtalbot @guparan @epernod