-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaOpenCL] Make it work with 20.06 #1361
Merged
hugtalbot
merged 4 commits into
sofa-framework:master
from
fredroy:opencl_compile_20_06
May 14, 2020
Merged
[SofaOpenCL] Make it work with 20.06 #1361
hugtalbot
merged 4 commits into
sofa-framework:master
from
fredroy:opencl_compile_20_06
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
location: plugins
pr: fix
Fix a bug
pr: status wip
Development in the pull-request is still in progress
pr: clean
Cleaning the code
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
May 2, 2020
hugtalbot
reviewed
May 6, 2020
<!--<CentralDifferenceSolver/>--> | ||
<!--<EulerImplicitSolver rayleighStiffness="0.1" rayleighMass="0.1" /> | ||
<CGLinearSolver/>--> | ||
<EulerExplicitSolver symplectic="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You decided to change the integration scheme of the example ? ^^ @fredroy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just took back the latest version in the examples of SofaSphFluid 🦆
hugtalbot
approved these changes
May 6, 2020
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 6, 2020
guparan
reviewed
May 12, 2020
guparan
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status ready
Approved a pull-request, ready to be squashed
labels
May 12, 2020
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: clean
Cleaning the code
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SOFA version of cleaning the Augean stables... 🐴
Make it compile and run (for the quadSpring scene)
And does not need the sofaOPENCL application.
Compile with the SofaSphPlugin as well, but the example scene crashes somewhere in the OpenCL kernel...
This PR:
Reviewers will merge only if all these checks are true.