Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrences #1353

Merged
merged 4 commits into from
May 27, 2020
Merged

[ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrences #1353

merged 4 commits into from
May 27, 2020

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Apr 30, 2020

this PR depends on #1351 where Data d_checkTopology has been introduced

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added location: plugins pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Apr 30, 2020
@epernod epernod self-assigned this Apr 30, 2020
@epernod epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 4, 2020
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 15, 2020
@epernod
Copy link
Contributor Author

epernod commented May 15, 2020

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor

ok fine, just could you explain why the error is sometime sent directly and sometimes it remains conditional to the checkTopology data ?

@epernod
Copy link
Contributor Author

epernod commented May 20, 2020

the checkTopology Data is only used to activate/unactivate the method CheckTopology.
It should not change message conditio. If it is the case, I missed it. Could you point the line?

@epernod epernod modified the milestone: v20.06 May 20, 2020
@hugtalbot hugtalbot changed the title [ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrencies [ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrences May 20, 2020
@hugtalbot
Copy link
Contributor

remove condition of warning, then ready

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 20, 2020
@epernod epernod requested a review from hugtalbot May 24, 2020 16:00
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 24, 2020
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 27, 2020
@hugtalbot hugtalbot merged commit 91afa07 into sofa-framework:master May 27, 2020
@epernod epernod deleted the inf_manifold branch August 12, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
2 participants
@epernod @hugtalbot