-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrences #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
location: plugins
pr: status to review
To notify reviewers to review this pull-request
pr: clean
Cleaning the code
labels
Apr 30, 2020
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 4, 2020
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
May 15, 2020
[ci-build][with-all-tests] |
ok fine, just could you explain why the error is sometime sent directly and sometimes it remains conditional to the checkTopology data ? |
the checkTopology Data is only used to activate/unactivate the method CheckTopology. |
hugtalbot
changed the title
[ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrencies
[ManifoldTopologies] Remove CHECK_TOPOLOGY macro occurrences
May 20, 2020
remove condition of warning, then ready |
hugtalbot
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 20, 2020
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
May 24, 2020
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR depends on #1351 where Data d_checkTopology has been introduced
This PR:
Reviewers will merge only if all these checks are true.