Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaFramework/CMake] Create configuration type dir before copying lib #1347

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 23, 2020

Solve #1331

For multi configuration projects (e.g Visual Studio), the macro was not checking if the directory was existing, and was copying the lib as the configuration name (which is obviously wrong 🐇 )
The fix creates the directory before copying (no need to check as CMake does not do anything if it already exists)


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Apr 23, 2020
@fredroy fredroy requested a review from guparan April 23, 2020 10:02
@fredroy fredroy changed the title [SofaFramework] Create configuration type dir before copying lib [SofaFramework/CMake] Create configuration type dir before copying lib Apr 24, 2020
@guparan guparan merged commit 274ce9a into sofa-framework:master Apr 30, 2020
@fredroy fredroy deleted the fix_configtype_dir branch June 11, 2020 11:35
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants