[SofaGui] Pass QDocBrowser as an option

[epernod]

• QDocBrowser will be build by default if Qt5WebEngine is found.
• Add option in cmake to enable the QDocBrowser (If I did it well) that will set Qt5WebEngine as required to warn user to install it if they want the browser.

---

This PR:

• builds with SUCCESS for all platforms on the CI.
• does not generate new warnings.
• does not generate new unit test failures.
• does not generate new scene test failures.
• does not break API compatibility.
• is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

[guparan]

Thanks @epernod but why?
@damienmarchal, your opinion on this?

[epernod]

I did like for QtChart. As it is not a module installed by default in Qt.
Otherwise be sure to tell user to install that module when installing Qt.

[jnbrunet]

Just my 2 cents, if there is an option to disable it, I'll probably use it even tho I have Qt5WebEngine installed, since I like to keep only the minimum options activated to reduce compilation time and I don't think I'll use this feature.

[damienmarchal]

Hi all,

Thanks Erik for the PR.

I'm not opposed to have this kind of option but I think it would be better to have and implementation that is not based on #ifdef (for reason we already discussed a lot).

[guparan]

• I would rename SOFAGUIQT_ENABLE_DOCBROWSER into SOFAGUIQT_ENABLE_QDOCBROWSER
• To avoid duplicated variables, use SOFAGUIQT_HAVE_QT5_WEBENGINE in code.
• In applications/sofa/gui/qt/SofaGuiQt.h.in, you have to add:

  #cmakedefine01 SOFAGUIQT_HAVE_QT5_WEBENGINE

[guparan]

This should be enough:

# QDocBrowser
option(SOFAGUIQT_ENABLE_QDOCBROWSER "Build the QDocBrowser. Qt5WebEngine is needed." OFF)
if (SOFAGUIQT_ENABLE_QDOCBROWSER)
    sofa_find_package(Qt5 COMPONENTS WebEngine WebEngineWidgets REQUIRED BOTH_SCOPES)
    set(QT_TARGETS ${QT_TARGETS} Qt5::WebEngine Qt5::WebEngineWidgets)
endif()

[hugtalbot]

If a solution is not found on the crash closing SOFA, I really ++++ this PR

[guparan]

I added the missing "enable by default if QDocBrowser is found" part 😉
Looks good now!

[hugtalbot]

It does fix my bug (prev!) @fredroy 👍
Problem did come from QtWebEng.