-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Fix alias warnings in scenes #1279
[All] Fix alias warnings in scenes #1279
Conversation
…logy / EulerExplicitSolver / RungeKutta4Solver in examples/Tutorials
…logy / EulerExplicitSolver / RungeKutta4Solver in examples/Components/
…logy / EulerExplicitSolver / RungeKutta4Solver in modules and benchmarks
…logy / EulerExplicitSolver / RungeKutta4Solver in plugins
[ci-build][force-full-build] (to see warnings) |
[ci-build][with-scene-tests] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR merged to soon, again... +4 scene test failures.
Too bad, I launched the build with scene tests specifically to catch this issues.
Do you have a few minutes to fix this @epernod ?
@@ -12,7 +12,7 @@ | |||
|
|||
<EulerImplicitSolver rayleighStiffness="0.1" rayleighMass="0.1" /> | |||
<CGLinearSolver iterations="25" tolerance="1.0e-9" threshold="1.0e-9" /> | |||
<!-- <EulerExplicitSolver /> --> | |||
<!-- <EulerExplicitSolverSolver /> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops!
@@ -9,7 +9,7 @@ | |||
|
|||
<EulerImplicitSolver rayleighStiffness="0.1" rayleighMass="0.1" /> | |||
<CGLinearSolver iterations="100" tolerance="1.0e-9" threshold="1.0e-9"/> | |||
<!-- <EulerExplicitSolver/> --> | |||
<!-- <EulerExplicitSolverSolver/> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops!
@@ -4,7 +4,7 @@ | |||
|
|||
<!-- Matrix system is diagonal because integration is explicit and Mass is diagonal --> | |||
<!-- No need for a LinearSolver --> | |||
<EulerExplicitSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="1" /> | |||
<EulerExplicitSolverSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops!
@@ -2,7 +2,7 @@ | |||
<RequiredPlugin name="SofaOpenglVisual"/> | |||
<Node name="DeformableObject"> | |||
|
|||
<EulerExplicitSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="0" symplectic="1" /> | |||
<EulerExplicitSolverSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="0" symplectic="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops!
Fix warning for
This PR:
Reviewers will merge only if all these checks are true.