[All] Fix alias warnings in scenes #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logy / EulerExplicitSolver / RungeKutta4Solver in examples/Tutorials
…logy / EulerExplicitSolver / RungeKutta4Solver in examples/Components/
…logy / EulerExplicitSolver / RungeKutta4Solver in modules and benchmarks
…logy / EulerExplicitSolver / RungeKutta4Solver in plugins
epernod
added
pr: status to review
|
[ci-build][force-full-build] (to see warnings) |
hugtalbot
added
pr: status ready
|
[ci-build][with-scene-tests] |
guparan
reviewed
Mar 27, 2020
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| <EulerImplicitSolver rayleighStiffness="0.1" rayleighMass="0.1" /> | |||
| <CGLinearSolver iterations="25" tolerance="1.0e-9" threshold="1.0e-9" /> | |||
| <!-- <EulerExplicitSolver /> --> | |||
| <!-- <EulerExplicitSolverSolver /> --> | |||
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| <EulerImplicitSolver rayleighStiffness="0.1" rayleighMass="0.1" /> | |||
| <CGLinearSolver iterations="100" tolerance="1.0e-9" threshold="1.0e-9"/> | |||
| <!-- <EulerExplicitSolver/> --> | |||
| <!-- <EulerExplicitSolverSolver/> --> | |||
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| <!-- Matrix system is diagonal because integration is explicit and Mass is diagonal --> | |||
| <!-- No need for a LinearSolver --> | |||
| <EulerExplicitSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="1" /> | |||
| <EulerExplicitSolverSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="1" /> | |||
| @@ -2,7 +2,7 @@ | |||
| <RequiredPlugin name="SofaOpenglVisual"/> | |||
| <Node name="DeformableObject"> | |||
|
|
|||
| <EulerExplicitSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="0" symplectic="1" /> | |||
| <EulerExplicitSolverSolver name="odeExplicitSolver" optimizedForDiagonalMatrix="0" symplectic="1" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning for
This PR:
Reviewers will merge only if all these checks are true.