[All] v19.12 changes + DocBrowser by Defrost #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # applications/sofa/gui/qt/panels/QDocBrowser.cpp
The code is automatically adding an alignedbox if nothing is provided in the constructor. This kind of test make no sense in the constructor as the "isSet" is sure to be set to false. The test should go in init or reinit. This commit fix that.
… similar with the one from python.array This is breaking but as this is a recently added function made by me I hope no one is still using it.
…th query instead of exception This behavior is similar to the getChild one.
This is a very annoying behavior when working with the -i option.
…_info("RequiredPlugin")
The string based version is there for non component only message.
For component it is much better to use the msg_info(this) or msg_info() version
that add the messge in the backlog of the component.
…d Matrices through mappings.
…e comments. Constraint are used only for contact so the help text was misleading.
Are constraints are used for much more than contact mangement.
The checking is now done in "init". This allows to create and add a ForceField into a a not yet finished tree while validity is checked later (at init())
PATHS parameter replaces LIBRARIES
guparan
added
enhancement
|
Corona-efficiency ! Well done ! |
|
OUch :) |
hugtalbot
reviewed
Mar 18, 2020
hugtalbot
reviewed
Mar 18, 2020
|
then ready |
|
[ci-build][with-all-tests] |
hugtalbot
added
pr: status ready
guparan
added
pr: status to review
|
Something is broken here. See tests results: https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-1275/CI_CONFIG=ubuntu_gcc-7,CI_PLUGINS=options,CI_TYPE=release/3/testReport/ |
|
Errors are fixed. Ready to merge! 🎉 |
guparan
added
pr: status ready
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Feb 23, 2024
[All] v19.12 changes + DocBrowser by Defrost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs regroups 2 works:
1. Changes for v19.12 packaging
2. Integration of DocBrowser by Defrost
WARNING: this will definitely break VS2015 compatibility
This PR:
Reviewers will merge only if all these checks are true.