[SofaKernel/SofaHelper] Add auto-friendly getWriteAccessors/getReadAcessor... #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessor/getWriteOnlyAccessor Not using an accessor is really bad but the syntax is not really friendly. So you can use this one which feature implicit typing and thus is easier: auto points = getReadAccessor(d_points) in place of: ReadAccessor<Data<Vec3> points = d_points; I also make code update more manageable. # Conflicts: # SofaKernel/modules/SofaHelper/src/sofa/helper/accessor.h
damienmarchal
added
the
pr: status to review
hugtalbot
added
enhancement
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SOFA not using an accessor is really bad (I mean really really bad), but the syntax is not really
friendly and thus discourage ppl to use it.
The PR adds few easing function smooth the syntax.
So you can now type:
auto points = getReadAccessor(d_points);
in place of:
ReadAccessor<Data points = d_points;
In also make code update more manageable, as the whole code based does not need to be changed if the d_points type change.
This PR:
Reviewers will merge only if all these checks are true.