Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaDefaultType] Add a Ray type. #1251

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[SofaDefaultType] Add a Ray type. #1251

merged 2 commits into from
Feb 13, 2020

Conversation

damienmarchal
Copy link
Contributor

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Feb 10, 2020
@damienmarchal damienmarchal mentioned this pull request Feb 10, 2020
Merged
6 tasks
@fredroy
Copy link
Contributor

fredroy commented Feb 10, 2020

Any plan to merge/use this defaulttype::Ray with collision::Ray ?

@hugtalbot hugtalbot added the enhancement About a possible enhancement label Feb 12, 2020
@hugtalbot hugtalbot mentioned this pull request Feb 12, 2020
Open
@hugtalbot
Copy link
Contributor

Refactoring to avoid confusion is good.
Another PR could refactor Ray : not a ray, change name, including iterator in the name (eg RayCollisionIterator ..). In the code, there should be refactoring with the defaulttype::Ray)
Issue created: #1255

@marques-bruno marques-bruno added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 12, 2020
@epernod epernod merged commit a9716a2 into sofa-framework:master Feb 13, 2020
@damienmarchal damienmarchal deleted the sofaAddRayDataType branch May 4, 2020 14:05
@guparan guparan added this to the v20.06 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.06
Development

Successfully merging this pull request may close these issues.
6 participants
@damienmarchal @fredroy @hugtalbot @guparan @marques-bruno @epernod