-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaKernel/CMakeLists.txt] Set the default compilation mode to c++17. #1249
Conversation
Because most compiler handle it properly and we are in 2020.
Err... Should we not wait for the CI to support c++17 (aka VS2017/2019) ? |
No, we should upgrade the CI to support this PR :) |
Update documentation (supported version) : see pages |
Hi all, What's is the progress in this ? |
We wait for CI environment, and Guillaume is actively working on it |
FYI external plugins can already be compiled with compilation mode c++17 |
Thanks for the answer, Actually we are using c++17 in our plugins since years. The problem is that not having sofa supporting c+17 means that when we want to make PRs to integrate some features into the sofa master we have to convert all the code to c++11. As it was agreed to allow Sofa to support c++17 a year ago I think it would be nice to have it asap, as it would free the contributors from reverting their codebase to c++11 to make PRs. So good luck to Guillaume. |
[ci-build][force-full-build][with-all-tests] |
CI is clear now.
|
Hi, |
I can't push on your branch. Did you forbid it? |
@damienmarchal Did you see my comment? |
I didn't do anything special on the branch |
error C2872: 'byte': ambiguous symbol
@guparan Any idea of the problem in windows ? |
[ci-build][with-regression-tests][with-scene-tests] |
[ci-build][with-all-tests] |
[SofaKernel/CMakeLists.txt] Set the default compilation mode to c++17.
Because most compiler handle it properly and we are in 2020.
This PR:
Reviewers will merge only if all these checks are true.