Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaHelper] FIX Eigen install path #1240

Merged
merged 1 commit into from
Jan 10, 2020
Merged

[SofaHelper] FIX Eigen install path #1240

merged 1 commit into from
Jan 10, 2020

Conversation

AlbanOdot
Copy link
Contributor

@AlbanOdot AlbanOdot commented Jan 9, 2020 •
edited by guparan
Loading

FIX install path for headers in unsupported/Eigen

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@AlbanOdot
fix eigen install
0f1e313 
Added unsupported to the install path
@guparan guparan changed the title fix eigen install [SofaHelper] FIX Eigen install path Jan 9, 2020
@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed labels Jan 9, 2020
@guparan guparan self-requested a review January 9, 2020 14:06
@guparan guparan merged commit 70a286b into sofa-framework:master Jan 10, 2020
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbanOdot @guparan