Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Fix order warnings #1239

Merged

Conversation

hugtalbot
Copy link
Contributor

All in the title


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jan 8, 2020
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Jan 8, 2020

Strange error on Mac clang:

Adding module SofaOpenglVisual
CMake Error at /Users/sofa/jenkins/sofa-ci-dev/workspace/sofa-framework/PR-1239/mac_clang-3.5_options_release/build/cmake/SofaFrameworkConfig.cmake:76 (find_package):
  Could not find a package configuration file provided by "GTest" with any of
  the following names:

    GTestConfig.cmake
    gtest-config.cmake

  Add the installation prefix of "GTest" to CMAKE_PREFIX_PATH or set
  "GTest_DIR" to a directory containing one of the above files.

@hugtalbot hugtalbot requested a review from guparan January 9, 2020 21:02
@guparan
Copy link
Contributor

guparan commented Jan 10, 2020

The error is gone apparently 👍

@guparan guparan added pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed and removed pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jan 10, 2020
@marques-bruno marques-bruno merged commit 7c665dc into sofa-framework:master Jan 10, 2020
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants