Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Remove deprecated SOFA_DEBUG macro #1232

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[SofaKernel] Remove deprecated SOFA_DEBUG macro #1232

merged 1 commit into from
Dec 13, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Dec 10, 2019

I suppose it is an old macro. Was not accesible from cmake config and always equal to true if compiled in debug mode.

only a few code was using it and were already checking NDebug as well.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Dec 10, 2019
@epernod epernod self-assigned this Dec 10, 2019
@epernod epernod added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Dec 10, 2019
@epernod
Copy link
Contributor Author

epernod commented Dec 10, 2019

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 11, 2019
@guparan guparan changed the title [sofaKernel] remove deprecated SOFA_DEBUG macro [SofaKernel] Remove deprecated SOFA_DEBUG macro Dec 11, 2019
@epernod epernod merged commit 1ec73d5 into sofa-framework:master Dec 13, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
@epernod epernod deleted the inf_sofadebug branch March 29, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
2 participants
@epernod @guparan