[SofaKernel] Consistent SofaFramework modules #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofa.ini is principally used by sofa::helper::system::FileRepository
This permits to access tests list easier.
Those tests were in frameworkextra_test before.
guparan
added
enhancement
…sofaframework # Conflicts: # SofaKernel/framework/sofa/helper/CMakeLists.txt
guparan
force-pushed
the
consistent_sofaframework
branch
from
c4a7182
to
58025a1
Compare
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a clean and consistent SofaKernel.
The idea is to make SofaFramework modules consistent with the rest of SOFA by moving them into
SofaKernel/modulesand reorganizing their tests.Main changes:
SofaKernel/framework/sofa/*goes toSofaKernel/moduleswith consistent namingSofaKernel/framework_test/*becomes XXX_test (where XXX is a SofaFramework module)SofaKernel/modules/sofa/*becomes XXX_simutest (where XXX is a SofaFramework module)<sofa_root>/modules/testsgoes to<sofa_root>/testsfor better readabilityThis PR is heavy but non-breaking. Package, module and library names stay the same. Include directories stay the same.
This PR:
Reviewers will merge only if all these checks are true.