[SofaKernel] Set BaseData to non-persistant by default #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a long standing issue in Sofa about not being able to save 'usable' scene in runSofa. Several PR had been made a long time ago. There is multiple problems among which: - keywords that are not Data field but parsing hook (eg: src, compatbility hook) needs to be converted into Data - the Data are not persistant or not depending on some object property but depend on their context of "use". Eg: *) a data changed in the GUI should be saved *) a data filled with a script shouldn't etc... To allow to control fine grain the state of a data is now set to non persitant by default and should only be activated specifically (by the GUI, or the script) if it is needed to save it. This is a behavior change...but it is on a totally broken feature :)
damienmarchal
added
the
pr: status to review
guparan
changed the title
guparan
added
pr: breaking
damienmarchal
added
pr: status to review
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long standing issue in Sofa about not being able to save 'usable' scene in runSofa.
This is the result of multiple problems combined together among which:
Eg:
*) a data changed in the GUI should be saved
*) a data filled with a script shouldn't
etc...
To allow to control fine grain the state of a data is now set to non persitant
by default and should only be activated specifically (by the GUI, or the script)
if it is needed to save it.
This is what this PR do, and despiste this is a behavior change...it is on a totally broken feature.
This PR:
Reviewers will merge only if all these checks are true.