Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaSphFluid] Several clean in the plugin components #1186

Merged
merged 15 commits into from
Oct 18, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 14, 2019

Only some cleaning in:

  • Class define macro
  • Data and member prefix
  • Move code from header to inl or cpp files

Update several plugin demo scenes.

SpatialGridContainer_00000001
SPHFluidForceField_benchmarks_00000001
SPHFluidSurfaceMapping_00000001


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added location: plugins pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 14, 2019
@epernod epernod self-assigned this Oct 14, 2019
@guparan guparan changed the title [SPH plugin] Several clean in the plugin components [SofaSphFluid] Several clean in the plugin components Oct 15, 2019
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 16, 2019
@epernod
Copy link
Contributor Author

epernod commented Oct 16, 2019

@guparan @hugtalbot could you check this plugin is compiled on the CI, I have a doubt

@hugtalbot
Copy link
Contributor

hugtalbot commented Oct 16, 2019

@epernod you could see that in the build output (cmake) and in the compilation.
In this case, no it isn't. We need to edit the appropriate scrit on CI. @guparan is on it

@simogasp simogasp mentioned this pull request Oct 16, 2019
6 tasks
@guparan
Copy link
Contributor

guparan commented Oct 16, 2019

Done, let's [ci-build][with-all-tests] again 👍

@hugtalbot hugtalbot merged commit 0b21411 into sofa-framework:master Oct 18, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
@epernod epernod deleted the inf_SPH_clean branch March 29, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants