Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Fix some AdvanceTimer log missing #1158

Merged
merged 3 commits into from
Sep 30, 2019
Merged

[SofaKernel] Fix some AdvanceTimer log missing #1158

merged 3 commits into from
Sep 30, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Sep 26, 2019

ADD some AdvanceTimer macro missing to understand the collision pipeline
FIX some end macro missing

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 26, 2019
@epernod epernod self-assigned this Sep 26, 2019
guparan
guparan approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 27, 2019
@guparan guparan merged commit 044412f into sofa-framework:master Sep 30, 2019
@epernod epernod deleted the inf_AdTimer branch October 16, 2019 16:48
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @guparan @hugtalbot