Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscForceField] Use doUpdateInternal API in MeshMatrixMass #1151

Merged
merged 2 commits into from
Sep 26, 2019
Merged

[SofaMiscForceField] Use doUpdateInternal API in MeshMatrixMass #1151

merged 2 commits into from
Sep 26, 2019

Conversation

hugtalbot
Copy link
Contributor

Finally apply the doUpdateInternal to MeshMatrixMass
This class should definitely be in SofaBaseMechanics ...

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Sep 20, 2019
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot changed the title [SofaMiscForceField] Updateinternal meshmatrixmass [SofaMiscForceField] Use doUpdateInternal API in MeshMatrixMass Sep 20, 2019
@epernod
Copy link
Contributor

epernod commented Sep 23, 2019 •
edited
Loading

there are 2 more unit tests failing on windows only, could you check if relevant to this PR or not. thx

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 25, 2019
@epernod epernod merged commit 4da2c23 into sofa-framework:master Sep 26, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @epernod @guparan