Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseMechanics] Use doUpdateInternal API in DiagonalMass #1150

Merged
merged 5 commits into from
Sep 26, 2019
Merged

[SofaBaseMechanics] Use doUpdateInternal API in DiagonalMass #1150

merged 5 commits into from
Sep 26, 2019

Conversation

hugtalbot
Copy link
Contributor

Following other components let's apply the updateInternal API to DiagonalMass

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Sep 20, 2019
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot changed the title [SofaBaseMechanics] Updateinternal diagonalmass [SofaBaseMechanics] Use doUpdateInternal API in DiagonalMass Sep 20, 2019
epernod
epernod reviewed Sep 23, 2019
View reviewed changes
SofaKernel/modules/SofaBaseMechanics/DiagonalMass.inl
Real mass=(Real)0;
Real total_mass=(Real)0;
Real mass=Real(0);
Real total_mass=Real(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need all those casts ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, this change was just made to fix the warning.
Do you think this could really slow down things ?

@hugtalbot
Copy link
Contributor Author

hugtalbot commented Sep 23, 2019 •
edited
Loading

Error of one test involving topological change : TopologicalChangeProcessor_test.Incise

[ RUN      ] TopologicalChangeProcessor_test.Incise
[DEPRECATED] [Sofa_test] Sofa_test & BaseSofa_test are now deprecated classes. To fix this message you should replace their usage by BaseTest, NumericTest or BaseSimulationTest to implement your tests
/Users/sofa/jenkins/sofa-ci-dev/workspace/sofa-framework/PR-1150/mac_clang-3.5_options_release/src/modules/SofaMiscTopology/SofaMiscTopology_test/scenes/IncisionTrianglesProcess.scn
[WARNING] [DiagonalMass(default5)] Negative value of vertexMass vector: vertexMass[357] = -0.138459
[ERROR]   [DiagonalMass(default5)] doUpdateInternal: incorrect update from vertexMass

maybe nodes/elements which are removed twice ... @epernod

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 25, 2019
@epernod epernod merged commit b3c6d3e into sofa-framework:master Sep 26, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod left review comments

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @epernod @guparan