-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseMechanics] Use doUpdateInternal API in DiagonalMass #1150
[SofaBaseMechanics] Use doUpdateInternal API in DiagonalMass #1150
Conversation
[ci-build][with-all-tests] |
Real mass=(Real)0; | ||
Real total_mass=(Real)0; | ||
Real mass=Real(0); | ||
Real total_mass=Real(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need all those casts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, this change was just made to fix the warning.
Do you think this could really slow down things ?
Error of one test involving topological change : TopologicalChangeProcessor_test.Incise
maybe nodes/elements which are removed twice ... @epernod |
Following other components let's apply the updateInternal API to DiagonalMass
This PR:
Reviewers will merge only if all these checks are true.