Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGeneralEngine] Added Rigid to Euler orientation export #1141

Merged
merged 1 commit into from
Sep 19, 2019
Merged

[SofaGeneralEngine] Added Rigid to Euler orientation export #1141

merged 1 commit into from
Sep 19, 2019

Conversation

polyakovkrylo
Copy link

Adds export from Rigid to Euler angles. One of the use case scenarios is attachment of a spotlight to a rigid body, described in this thread

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Sep 16, 2019
@hugtalbot
Copy link
Contributor

Thank you and congratulations for your contributions @polyakovkrylo ! Erik already approved it, we always let about 7 days to all reviewers for taking a look.

@hugtalbot hugtalbot changed the title Added Rigid to Euler orientation export [SofaGeneralEngine] Added Rigid to Euler orientation export Sep 16, 2019
@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 18, 2019
@guparan guparan merged commit e2fac75 into sofa-framework:master Sep 19, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
4 participants
@polyakovkrylo @hugtalbot @epernod @guparan