Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGui] Fix VideoRecorder #1138

Merged

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Sep 5, 2019

Here is a fix for the VideoRecorder broken since #1121 due to change in API and in CMakeLists.

  • Add findPackagae for ffmpeg since add_definitions does not propagate SOFA_HAVE_FFMPEG_EXEC above the caller project
  • Change function initRecorder including both code extension and code name

Here you are @fspadoni ;)


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Sep 5, 2019
@hugtalbot hugtalbot changed the title [SofaGui] Fix videorecorder after1121 [SofaGui] Fix videorecorder Sep 5, 2019
@hugtalbot hugtalbot changed the title [SofaGui] Fix videorecorder [SofaGui] Fix VideoRecorder Sep 5, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 9, 2019
@guparan guparan merged commit 04a5585 into sofa-framework:master Sep 9, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants