Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseLinearSolver][FullMatrix] Restore fast clear function #1128

Merged
merged 2 commits into from
Sep 12, 2019
Merged

[SofaBaseLinearSolver][FullMatrix] Restore fast clear function #1128

merged 2 commits into from
Sep 12, 2019

Conversation

fspadoni
Copy link
Contributor

@fspadoni fspadoni commented Aug 22, 2019 •
edited
Loading

A few minor change in matrix class to improve performance

FullMatrix: Restore fast matrix clear function
MatExpr: Remove console output in addTo function

Clear function in visual studio profiler

current: 0.51% inclusive samples
doubleForLoopClear

std::fill: 0.18% inclusive samples
stdfillClear

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fspadoni fspadoni added the pr: status to review To notify reviewers to review this pull-request label Aug 22, 2019
@hugtalbot hugtalbot added the pr: clean Cleaning the code label Aug 23, 2019
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Aug 28, 2019
hugtalbot
hugtalbot reviewed Aug 28, 2019
View reviewed changes
SofaKernel/modules/SofaBaseLinearSolver/FullMatrix.h
for (Index i = 0; i<nRow; ++i)
for (Index j = 0; j<nCol; ++j)
data[i*pitch + j] = (Real)0;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @courtecuisse could you let us know what you think about this change proposed by Federico in the clear() function?

@fspadoni fspadoni added the pr: status to review To notify reviewers to review this pull-request label Sep 4, 2019
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request labels Sep 4, 2019
@fspadoni fspadoni added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 11, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 11, 2019
@epernod epernod merged commit faf8c0f into sofa-framework:master Sep 12, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot left review comments

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fspadoni @hugtalbot @guparan @epernod