Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaKernel] Use links for input and output topologies of the barycentric mapping #1125

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

jnbrunet
Copy link
Contributor

Something, when having multiple topologies in the same node as the input state, the barycentric mapping will get the wrong input topology since it rely only on fromModel->getContext. This PR fixes this by adding links for the input and output topologies.

Also some reformatting of the input topology type detection with a goto statement...a good example as to where goto can be useful :-)


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@jnbrunet jnbrunet added the pr: status to review To notify reviewers to review this pull-request label Aug 21, 2019
@hugtalbot
Copy link
Contributor

[ci-build][with-all-tests]

@guparan guparan added pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 23, 2019
@guparan guparan merged commit e7806e9 into sofa-framework:master Aug 23, 2019
@jnbrunet jnbrunet deleted the barycentric_mapping branch August 23, 2019 14:19
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants