Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaMacros] FIX default module version #1123

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Aug 20, 2019

This should fix the CUDA issue on CI.

Issue was due to SofaCUDA having a version number (instead of NO_VERSION) and thus not being deactivated for scene tests by CI scripts (main.sh).

We chose to deactivate SofaCUDA for scene tests because VMs can't run CUDA (or can they?).
In CI, SofaCUDA is only compiled, never executed.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

Do not apply default version to plugins.
@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Aug 20, 2019
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 21, 2019
@hugtalbot
Copy link
Contributor

It fixes indeed the 615 crashes in option ! 👍

@guparan guparan merged commit dbf418d into sofa-framework:master Aug 21, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants