Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaTests] Fix small bugs in the Multi2Mapping_test #1078

Merged
merged 2 commits into from
Jun 20, 2019
Merged

[SofaTests] Fix small bugs in the Multi2Mapping_test #1078

merged 2 commits into from
Jun 20, 2019

Conversation

adagolodjo
Copy link
Contributor

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@adagolodjo adagolodjo added the issue: bug (minor) Bug affecting only some users or with no major impact on the framework label Jun 12, 2019
@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Jun 14, 2019
ChristianDuriez
ChristianDuriez approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@ChristianDuriez ChristianDuriez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good: the Multi2Mapping should allow for having 2 different DataTypes as input. The previous implementation was considering that only 1 input DataType was possible.
The bug fix allows now for 2 input DataTypes (In1Deriv / In2Deriv).
I think the change made by @younesssss should be approved.

@damienmarchal damienmarchal added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jun 18, 2019
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 19, 2019
@marques-bruno marques-bruno merged commit c206057 into sofa-framework:master Jun 20, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@guparan guparan added pr: fix Fix a bug and removed issue: bug (minor) Bug affecting only some users or with no major impact on the framework labels Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianDuriez ChristianDuriez ChristianDuriez approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
6 participants
@adagolodjo @ChristianDuriez @guparan @damienmarchal @marques-bruno @epernod