[Sofa] Remove bunch of warnings (again) #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
hugtalbot
reviewed
May 27, 2019
| virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Quad>::EMoved* /*event*/) {} | ||
| virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Tetrahedron>::EMoved* /*event*/) {} | ||
| virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Hexahedron>::EMoved* /*event*/) {} | ||
|
|
There was a problem hiding this comment.
@epernod could you validate these empty functions?
There was a problem hiding this comment.
If non-regression tests say ok, I would say ok as well.
|
[ci-build][with-all-tests] |
epernod
reviewed
Jun 5, 2019
| @@ -113,7 +113,7 @@ These steps are explained in more detail in the sections that follow. | |||
| } | |||
|
|
|||
| private: | |||
| static void eventCallback(ConstFSEventStreamRef streamRef, void *clientCallBackInfo, size_t numEvents, void *eventPaths, const FSEventStreamEventFlags eventFlags[], const FSEventStreamEventId eventIds[]) | |||
| static void eventCallback(ConstFSEventStreamRef /*streamRef*/, void *clientCallBackInfo, size_t /*numEvents*/, void */*eventPaths*/, const FSEventStreamEventFlags /*eventFlags*/[], const FSEventStreamEventId /*eventIds*/[]) | |||
There was a problem hiding this comment.
not better to use SOFA_UNUSED ?
epernod
reviewed
Jun 5, 2019
| @@ -183,7 +183,7 @@ int FileMonitor::addFile(const std::string& directoryname, const std::string& fi | |||
| volatile sig_atomic_t keep_going = 1; | |||
|
|
|||
| /* The signal handler just clears the flag and re-enables itself. */ | |||
| void catch_alarm (int sig) | |||
| void catch_alarm (int /*sig*/) | |||
| @@ -24,7 +24,7 @@ namespace sofa | |||
| return ::operator new(sz); | |||
| } | |||
|
|
|||
| void free(void* ptr, std::size_t sz) final | |||
| void free(void* ptr, std::size_t /* sz */) final | |||
| @@ -87,9 +87,9 @@ public: | |||
| typedef typename DataTypes::Coord Coord; | |||
| VectorSpringForceField<DataTypes>* dest; | |||
| Loader(VectorSpringForceField<DataTypes>* dest) : dest(dest) {} | |||
| virtual void addVectorSpring(int m1, int m2, SReal ks, SReal kd, SReal /*initpos*/, SReal restx, SReal resty, SReal restz) | |||
| virtual void addVectorSpring(size_t m1, size_t m2, SReal ks, SReal kd, SReal /*initpos*/, SReal restx, SReal resty, SReal restz) | |||
| @@ -49,7 +49,7 @@ class SOFA_GRAPH_COMPONENT_API SceneCheckerListener : public SceneLoader::Listen | |||
|
|
|||
| // Do nothing on reload | |||
| virtual void rightBeforeReloadingScene() override {} | |||
| virtual void rightAfterReloadingScene(Node::SPtr node) override {} | |||
| virtual void rightAfterReloadingScene(Node::SPtr /* node */) override {} | |||
epernod
added
pr: status wip
|
@epernod is that OK in the TopologySomethingHandler ? |
fredroy
added
pr: status to review
|
[ci-build][force-full-build] 😉 |
guparan
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- last (?) override warnings
2- add a preprocessor define to remove OpenGL deprecated message on MacOS
3- various other warnings
I would appreciate if @epernod could check how the warnings from TopologyHandler has been managed ;) (commit a85cdae )
This PR:
Reviewers will merge only if all these checks are true.