-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sofa] Remove bunch of warnings (again) #1065
Conversation
virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Quad>::EMoved* /*event*/) {} | ||
virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Tetrahedron>::EMoved* /*event*/) {} | ||
virtual void ApplyTopologyChange(const TopologyChangeElementInfo<Topology::Hexahedron>::EMoved* /*event*/) {} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epernod could you validate these empty functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If non-regression tests say ok, I would say ok as well.
[ci-build][with-all-tests] |
@@ -113,7 +113,7 @@ These steps are explained in more detail in the sections that follow. | |||
} | |||
|
|||
private: | |||
static void eventCallback(ConstFSEventStreamRef streamRef, void *clientCallBackInfo, size_t numEvents, void *eventPaths, const FSEventStreamEventFlags eventFlags[], const FSEventStreamEventId eventIds[]) | |||
static void eventCallback(ConstFSEventStreamRef /*streamRef*/, void *clientCallBackInfo, size_t /*numEvents*/, void */*eventPaths*/, const FSEventStreamEventFlags /*eventFlags*/[], const FSEventStreamEventId /*eventIds*/[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not better to use SOFA_UNUSED ?
@@ -183,7 +183,7 @@ int FileMonitor::addFile(const std::string& directoryname, const std::string& fi | |||
volatile sig_atomic_t keep_going = 1; | |||
|
|||
/* The signal handler just clears the flag and re-enables itself. */ | |||
void catch_alarm (int sig) | |||
void catch_alarm (int /*sig*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOFA_UNUSED
@@ -24,7 +24,7 @@ namespace sofa | |||
return ::operator new(sz); | |||
} | |||
|
|||
void free(void* ptr, std::size_t sz) final | |||
void free(void* ptr, std::size_t /* sz */) final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOFA_UNUSED
@@ -87,9 +87,9 @@ public: | |||
typedef typename DataTypes::Coord Coord; | |||
VectorSpringForceField<DataTypes>* dest; | |||
Loader(VectorSpringForceField<DataTypes>* dest) : dest(dest) {} | |||
virtual void addVectorSpring(int m1, int m2, SReal ks, SReal kd, SReal /*initpos*/, SReal restx, SReal resty, SReal restz) | |||
virtual void addVectorSpring(size_t m1, size_t m2, SReal ks, SReal kd, SReal /*initpos*/, SReal restx, SReal resty, SReal restz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOFA_UNUSED
@@ -49,7 +49,7 @@ class SOFA_GRAPH_COMPONENT_API SceneCheckerListener : public SceneLoader::Listen | |||
|
|||
// Do nothing on reload | |||
virtual void rightBeforeReloadingScene() override {} | |||
virtual void rightAfterReloadingScene(Node::SPtr node) override {} | |||
virtual void rightAfterReloadingScene(Node::SPtr /* node */) override {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SOFA_UNUSED
@epernod is that OK in the TopologySomethingHandler ? |
[ci-build][force-full-build] 😉 |
1- last (?) override warnings
2- add a preprocessor define to remove OpenGL deprecated message on MacOS
3- various other warnings
I would appreciate if @epernod could check how the warnings from TopologyHandler has been managed ;) (commit a85cdae )
This PR:
Reviewers will merge only if all these checks are true.