Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaPython] Fix duplicate symbol #1036

Merged
merged 2 commits into from
May 13, 2019
Merged

[SofaPython] Fix duplicate symbol #1036

merged 2 commits into from
May 13, 2019

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented May 11, 2019

In some (very) rare cases, if the user links two libs (in which was included the header PythonScriptControllerHelper.h), compilation should throw an error of duplicate symbol for PythonScriptController_parametersToVector().
I got the problem while making static libraries.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status wip Development in the pull-request is still in progress labels May 11, 2019
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 13, 2019
@guparan guparan merged commit c649c52 into sofa-framework:master May 13, 2019
@fredroy fredroy deleted the fix_PythonScriptControllerhelper_link branch May 13, 2019 13:21
@guparan guparan removed pr: status to review To notify reviewers to review this pull-request labels Jun 20, 2019
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
2 participants
@fredroy @guparan