Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaCuda] Fix several Cuda example scenes #1000

Merged
merged 6 commits into from
Apr 24, 2019
Merged

[SofaCuda] Fix several Cuda example scenes #1000

merged 6 commits into from
Apr 24, 2019

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Apr 18, 2019 •
edited by damienmarchal
Loading

  • Clean all Cuda/Cpu scene examples from aliases.
  • Fix DiagonalMass, MeshMatrixMass, IdentityMapping and BarycentricMapping class template declaration.
  • Fix several scenes behavior.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added location: plugins pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Apr 18, 2019
@epernod epernod self-assigned this Apr 18, 2019
@epernod
Copy link
Contributor Author

epernod commented Apr 19, 2019

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 24, 2019
@damienmarchal damienmarchal merged commit ac5ae2f into sofa-framework:master Apr 24, 2019
@hugtalbot
Copy link
Contributor

Here we are!
The 1000th PR from @epernod merged by @damienmarchal ! 👍

@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@epernod epernod deleted the cuda_win_fix branch September 20, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
4 participants
@epernod @hugtalbot @guparan @damienmarchal