Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #383

Closed
wants to merge 5 commits into from
Closed

Conversation

pchaillo
Copy link

Hi,

I just add a detail on the pybind11 library in order to make sure that people install pybind11 with apt-get and not with pip.

Bests,

Paul

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with pip? Can we do something to fix it?

README.md Outdated Show resolved Hide resolved
@alxbilger
Copy link
Contributor

Hi @pchaillo, can you give us some news about this PR. What happens if you install with pip?

TODO:

  • Add this detail in the doc
  • Mention this for Linux only

pchaillo and others added 3 commits February 14, 2024 14:55
Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
@bakpaul
Copy link
Contributor

bakpaul commented Mar 15, 2024

Hello, I am sorry but I don't think those packages are required, installing through pip is enough.
Actually, it is even recommended to use pip installed packages for as many python dependency as possible, to enable multiple python version usage on your system.

But, doing so, pybind11 will not be found automatically by CMake, you'll need to modify a the CMake option CMAKE_PREFIX_PATH and append the path to pybind11 cmake files. For instance of our github builders we retrieve this folder by calling pybind11_DIR="$(pybind11-config --cmakedir)". On my ubuntu it looks like that : /usr/lib/python3/dist-packages/pybind11/share/cmake/pybind11.

Could you try this and see if it works for you and if it does, we can close this PR.

@hugtalbot
Copy link
Contributor

Let's close the PR @pchaillo
If you get some time to work on it again, please feel free to reopen it

@hugtalbot hugtalbot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants