-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Rebuild the sphinx documentation for SofaPython3 #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
damienmarchal
commented
Jun 7, 2023
•
edited by hugtalbot
Loading
edited by hugtalbot
- Fix and rebuild the sphinx documentation for SofaPython3
- Clean the doc architecture
- Add and update documentation for v23.06
- Automatize the generation at each release
hugtalbot
changed the title
Xp readthedocs
[doc] Rebuild the sphinx documentation for SofaPython3
Aug 31, 2023
hugtalbot
added
pr: status to review
enhancement
New feature or request
and removed
pr: status wip
labels
Aug 31, 2023
# Conflicts: # bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Node_doc.h # bindings/Sofa/src/SofaPython3/Sofa/Core/Submodule_Core.cpp # docs/sphinx/source/content/modules/SofaExporter/index.rst
Hi Hugo do we go for a merge ? |
@hugtalbot ready to merge? It seems there is failing unit test. Not sure it is related to this PR though |
fredroy
requested changes
Sep 26, 2023
@@ -69,7 +69,7 @@ void Prefab::reinit() | |||
doReInit(); | |||
|
|||
/// Beurk beurk beurk | |||
sofa::simulation::node::init(this); | |||
sofa::simulation::getSimulation()->init(this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a revert of #357
I think this branch must be rebased on the current master
Moved into a separated PR .#449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.