Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] Update RodSection, WireRestShape and All BeamInterpolation to correctly redirect the getters to the Data #155

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 19, 2024

Add getter for:

  • getBeamSection
  • getInterpolationParameters
  • getMechanicalParameters

Depending on the modeling:

  • If BeamInterpolation is used. The method are overidden from BaseBeamInterpolation to use internal Data from BeamInterpolation.
  • If WireBeamInterpolation is used: The overidden methods return the values from the WireRestShape which redirect to the corresponding method inside the BaseRodSection (depending on the current curvilinar abscissa)

Breaking:

  • Remove the method GetYoungModulus by getMechanicalParameters as Poisson Ratio and Density of mass is also return at the same time.
  • Rename several methods from xxxxParam to xxxxParameters and to xxxxParametersAtX (when depending on the curvilinear abscissa)
  • Remove pointer to the WireRestShape in the FEM, now only use the pointer to the BaseInterpolation component which hide the use of the WireRestShape if it is as WireBeamInterpolation.

Todo: remove the MassDensity Data from the FEM. It should be defined either in RodSection or in BeamInterpolation.

…orrectly redirect the getters to the Data for: getBeamSection, getInterpolationParameters and getMechanicalParameters. Remove the now useless pointer to the RestShape inside the FEM. Go only through the Interpolation component.
@epernod epernod added pr: clean pr: status to review To notify reviewers to review this pull-request labels Jul 19, 2024
@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 26, 2024
@bakpaul bakpaul merged commit d966a31 into sofa-framework:master Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants