Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not provide deep copy method,be like deep copy of array or object? #384

Open
yyqxjwxy opened this issue Mar 13, 2024 · 8 comments
Open

Comments

@yyqxjwxy
Copy link

No description provided.

@shtse8
Copy link

shtse8 commented Mar 14, 2024

Deep cloning objects and arrays can indeed get quite complex, especially when you consider all the potential edge cases like nested structures and special types (like Date, RegExp). The aim of Radash is to keep things simple and efficient, focusing on the most common use cases.

Adding a deep copy feature would significantly increase the complexity and size of the library. That’s why it’s left out, allowing users to integrate or implement their own solutions for specific needs. There are dedicated libraries out there that handle deep cloning well, which might be worth looking into for more complex requirements.

I hope this makes sense and aligns with your expectations for using Radash.

@qingzhoufeihu
Copy link

Now the packaging tools all have tree shaking functions, if the developer does not reference the deep copy function, it will not be packaged into the final bundle, so there is no need to consider the package size.

@troy351
Copy link

troy351 commented Mar 19, 2024

Maybe structuredClone ?

@qingzhoufeihu
Copy link

We could use immer instead

@Gemini-0529
Copy link

Now the packaging tools all have tree shaking functions, if the developer does not reference the deep copy function, it will not be packaged into the final bundle, so there is no need to consider the package size.

日常需求感觉JSON.parse JSON.stringify就够了

@CavalcanteLeo
Copy link

CavalcanteLeo commented Jun 23, 2024

Now the packaging tools all have tree shaking functions, if the developer does not reference the deep copy function, it will not be packaged into the final bundle, so there is no need to consider the package size.

日常需求感觉JSON.parse JSON.stringify就够了

https://dev.to/builderio/deep-cloning-objects-in-javascript-the-modern-way-17kf

json parse has some problems as well...

Extracted from the article:

Take this as an example:

const calendarEvent = {
  title: "Builder.io Conf",
  date: new Date(123),
  attendees: ["Steve"]
}
// 🚩 JSON.stringify converted the `date` to a string
const problematicCopy = JSON.parse(JSON.stringify(calendarEvent))

If we log problematicCopy, we would get:

{
  title: "Builder.io Conf",
  date: "1970-01-01T00:00:00.123Z"
  attendees: ["Steve"]
}

That’s not what we wanted! date is supposed to be a Date object, not a string.

This happened because JSON.stringify can only handle basic objects, arrays, and primitives. Any other type can be handled in hard to predict ways. For instance, Dates are converted to a string. But a Set is simply converted to {}.

JSON.stringify even completely ignores certain things, like undefined or functions.

For instance, if we copied our kitchenSink example with this method:

const kitchenSink = {
  set: new Set([1, 3, 3]),
  map: new Map([[1, 2]]),
  regex: /foo/,
  deep: { array: [ new File(someBlobData, 'file.txt') ] },
  error: new Error('Hello!')
}
const veryProblematicCopy = JSON.parse(JSON.stringify(kitchenSink))

We would get:

{
  "set": {},
  "map": {},
  "regex": {},
  "deep": {
    "array": [
      {}
    ]
  },
  "error": {},
}

Ew!

Oh yeah, and we had to remove the circular reference we originally had for this, as JSON.stringify simply throws errors if it encounters one of those.

@aleclarson
Copy link

Hello @yyqxjwxy @qingzhoufeihu @CavalcanteLeo and others, we've added a cloneDeep function over at the Radashi fork. Read the docs here. If you have any feedback, comment on this PR.

You can use it today by installing radashi@beta. An official release is pending until I get the docs website running. You can check out the CHANGELOG.md to see everything else we've added/fixed.

@skylingfly
Copy link

what a pity, if there's no deep clone function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants