-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1620446: add timedelta integration tests and notebooks #2142
SNOW-1620446: add timedelta integration tests and notebooks #2142
Conversation
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Are there any positive tests here? |
@sfc-gh-lmukhopadhyay Binary op subtraction (datetime - datetime = timedelta) was merged recently. Can you ensure this is part of the tests in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a readme describe how to run notebook tests locally? Like how to setup the credentials for example?
@sfc-gh-evandenberg The notebooks have some positive tests, but the idea is to re-enable the negative tests in test_timedelta_ops.py and undo the commented cells in the notebooks once all Timedelta operations are implemented, as outlined in this ticket here |
@sfc-gh-azhan The credentials should already be setup, provided you've populated your tests.parameters file with CONNECTION_PARAMETERS. The notebooks can then be run by running |
Please add one in the notebook test folder thanks! |
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
Signed-off-by: Labanya Mukhopadhyay <labanya.mukhopadhyay@snowflake.com>
@sfc-gh-nkrishna This case should be in the MIMIC nb but is also explicitly in TimeSeriesTesting.ipynb now |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1620446
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adding notebooks with timedelta usecases and negative integration tests