-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tqdm progress bar on label fit method #1649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 68 68
Lines 2157 2163 +6
Branches 348 350 +2
=======================================
+ Hits 2099 2105 +6
Misses 30 30
Partials 28 28
|
@bhancock8, @brahmaneya, requesting a review for this PR |
|
Thank you for this PR contribution, @anerirana! (And apologies for the delay—I was out of office this past week). Yes, I think adding a |
@bhancock8, thanks for the review. Added the progress bar parameter as discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks for the edit and new unit test. Good to merge!
@bhancock8 I don't have write access to this repository, you will have to merge the PR. |
Thanks @anerirana for the contribution!
Fixes #1624
Description of proposed changes
Added a tqdm progress bar when
fit()
method onLabelModel
is called. It updates after each epoch.When log frequency for loss reporting is enabled, it will be formatted this way.
Please let me know if I should add a
progress_bar
parameter tofit()
, similar toapply()
method inPandasLFApplier
Related issue(s)
Fixes #1624
Test plan
No new test has been added, as these changes do not modify the logic
Checklist
Need help on these? Just ask!
tox -e complex
and/ortox -e spark
if appropriate.