Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit seed setting #1454

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Explicit seed setting #1454

merged 1 commit into from
Sep 6, 2019

Conversation

henryre
Copy link
Member

@henryre henryre commented Sep 6, 2019

Description of proposed changes

Move to setting seeds explicitly. Ambiguous set_seed has caused a few issues, and this reduces our dependency on PyTorch.

Test plan

Updated unit tests, all passing.

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have run tox -e complex and/or tox -e spark if appropriate.
  • All new and existing tests passed.

@henryre henryre requested a review from a team September 6, 2019 23:02
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1454 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   97.58%   97.58%   -0.01%     
==========================================
  Files          55       55              
  Lines        2032     2029       -3     
  Branches      334      334              
==========================================
- Hits         1983     1980       -3     
  Misses         22       22              
  Partials       27       27
Impacted Files Coverage Δ
snorkel/utils/core.py 94.23% <ø> (-0.6%) ⬇️
snorkel/labeling/model/label_model.py 95.76% <100%> (+0.04%) ⬆️

@henryre henryre merged commit a9c28a2 into master Sep 6, 2019
@henryre henryre deleted the seed branch September 6, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants