Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convergence (integration) test for MultitaskClassifier #1442

Merged
merged 4 commits into from
Sep 5, 2019

Conversation

bhancock8
Copy link
Member

Description of proposed changes

Add integration test confirming that MultitaskClassifier with two tasks (with simple, linear decision boundaries) converges to near-perfect scores when trained.

Test plan

Added new test.

Checklist

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bhancock8 bhancock8 requested a review from a team September 4, 2019 21:05
Copy link
Member

@vincentschen vincentschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment nit, otherwise LGTM!

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #1442 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1442   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          55       55           
  Lines        1996     1996           
  Branches      327      327           
=======================================
  Hits         1947     1947           
  Misses         22       22           
  Partials       27       27
Impacted Files Coverage Δ
snorkel/classification/multitask_classifier.py 96.53% <ø> (ø) ⬆️
snorkel/analysis/scorer.py 100% <0%> (ø) ⬆️

@bhancock8 bhancock8 merged commit ad5731a into master Sep 5, 2019
@bhancock8 bhancock8 deleted the clf_integ_test branch September 5, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants