Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15247 - make pie chart on dashboard respect the “show archived… #15270

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 12, 2024

The dashboard pie chart previously did not respect the "show archived in lists" setting. Now it does.

Fixes #15247

…” setting

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit c9f8a84 into develop Aug 12, 2024
6 of 9 checks passed
@snipe snipe deleted the fixes/make_dashboard_pie_respect_show_in_list branch August 12, 2024 16:59
Copy link

what-the-diff bot commented Aug 12, 2024

PR Summary

  • Enhancement in Model Import
    The code now utilizes App\Models\Setting in the StatuslabelsController.php file. This allows better management and efficient access to database structures.

  • Advanced Status Labels Retrieval
    The system now has an improved way of retrieving statuslabels. Depending on the preference set in settings, the system can now fetch statuslabels with or without associated archived assets.

  • Initialization of Total Variable
    There's a small change in declaring the variable $total - it's now initially an empty array. This provides better control over this variable, aiding in the maintenance and predictability of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant