Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed API key missing translations #15055

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixed API key missing translations #15055

merged 1 commit into from
Jul 9, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 9, 2024

This makes more of the strings on the API keys page translatable.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jul 9, 2024

PR Summary

  • Improved Internationalization Across the App
    This PR carries out quite a few changes that revolve around replacing hardcoded strings within the application with their translated versions. The benefits of this are twofold; firstly, it makes the application more accessible to non-English speaking users, and secondly, it facilitates easy translation into any language. Changes were made in the following areas:

  • In the Profile Controller, a hardcoded string was replaced with a translated version.

  • The language resource files were enriched with several additions, including messages to denote success during API key creation, error messages, button labels, and column header labels among others.

  • For Personal Access Tokens interface, hardcoded strings such as "Create New Token" and "Delete" were swapped for their translated counterparts.

  • New sections were added to display translated messages which alert users when a new personal access token (a key that authorizes API calls) is created.

All these changes help to make the application much friendlier for international users and simpler to localize in the future.

@snipe snipe merged commit 14fa5d7 into develop Jul 9, 2024
8 of 9 checks passed
@snipe snipe deleted the more_translations branch July 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant